Remove last uses of old Azure SDK for Go #4425
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4425 +/- ##
=======================================
Coverage 61.97% 61.97%
=======================================
Files 188 188
Lines 18765 18765
=======================================
Hits 11630 11630
Misses 6497 6497
Partials 638 638 ☔ View full report in Codecov by Sentry. |
|
/retest |
| @@ -58,7 +56,7 @@ func Get() Info { | |||
| GoVersion: runtime.Version(), | |||
| Compiler: runtime.Compiler, | |||
| Platform: fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH), | |||
| AzureSdkVersion: azuresdkversion.Number, | |||
| AzureSdkVersion: "SDK track2", | |||
There was a problem hiding this comment.
There is no single version string provided any longer for the SDK (except arguably in an internal package that's not accessible). So I think all we can do is hard-code it from now on.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 60ba6ab0088de92aada39093e337fb876d538f22
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removes the final two vestiges of the "track 1" version of Azure SDK for Go in the CAPZ codebase.
Which issue(s) this PR fixes:
Refs #3409
Special notes for your reviewer:
TODOs:
Release note: